Re: [PATCH] gpu: drm: i915: fix error return code of igt_buddy_alloc_smoke()

On 2021/3/8 17:18, Chris Wilson wrote:

Quoting Jia-Ju Bai (2021-03-08 08:59:52)

...

When i915_random_order() returns NULL to order, no error return code of igt_buddy_alloc_smoke() is assigned. To fix this bug, err is assigned with -EINVAL in this case.

It would not be EINVAL since that is used for a reference failure, but in this case the idea was to return 0 as no testing was done and the ENOMEM was raised before testing began i.e. not an internal and unexpected driver allocation failure. -Chris

Okay, thanks for your reply :)

Best wishes, Jia-Ju Bai