Hi Matthew,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on v5.18 next-20220525] [cannot apply to drm-intel/for-linux-next drm/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Auld/small-BAR-uapi-b... base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: x86_64-rhel-8.3-kunit (https://download.01.org/0day-ci/archive/20220526/202205261034.CoXEwzSb-lkp@i...) compiler: gcc-11 (Debian 11.3.0-1) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/614521eb68cc1e72a489c1c7968273... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Matthew-Auld/small-BAR-uapi-bits/20220526-024641 git checkout 614521eb68cc1e72a489c1c796827329c98bf031 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/i915/
If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
drivers/gpu/drm/i915/i915_ttm_buddy_manager.c:379: warning: expecting prototype for i915_ttm_buddy_man_visible_size(). Prototype was for i915_ttm_buddy_man_avail() instead
vim +379 drivers/gpu/drm/i915/i915_ttm_buddy_manager.c
367 368 /** 369 * i915_ttm_buddy_man_visible_size - Query the avail tracking for the manager. 370 * 371 * @man: The buddy allocator ttm manager 372 * @avail: The total available memory in pages for the entire manager. 373 * @visible_avail: The total available memory in pages for the CPU visible 374 * portion. Note that this will always give the same value as @avail on 375 * configurations that don't have a small BAR. 376 */ 377 void i915_ttm_buddy_man_avail(struct ttm_resource_manager *man, 378 u64 *avail, u64 *visible_avail)
379 {
380 struct i915_ttm_buddy_manager *bman = to_buddy_manager(man); 381 382 mutex_lock(&bman->lock); 383 *avail = bman->mm.avail >> PAGE_SHIFT; 384 *visible_avail = bman->visible_avail; 385 mutex_unlock(&bman->lock); 386 } 387