Re: [PATCH] drm/hisilicon: Code refactoring for hibmc_drv_vdac

Thank you, your suggestion is accepted and I will issue v2

在 2020/4/11 11:43, Joe Perches 写道:

On Sat, 2020-04-11 at 10:49 +0800, Tian Tao wrote:

...

code refactoring for hibmc_drv_vdac.c, no actual function changes.

Seems sensible.

...

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c

[]

...

@@ -109,13 +83,6 @@ int hibmc_vdac_init(struct hibmc_drm_private *priv) struct drm_connector *connector; int ret;

• connector = hibmc_connector_init(priv);
• if (IS_ERR(connector)) {

• DRM_ERROR("failed to create connector: %ld\n",
  

• 	  PTR_ERR(connector));
  

• return PTR_ERR(connector);
  

• }
• encoder = devm_kzalloc(dev->dev, sizeof(*encoder), GFP_KERNEL); if (!encoder) { DRM_ERROR("failed to alloc memory when init encoder\n");

The alloc error messages could be removed.

...

@@ -131,6 +98,21 @@ int hibmc_vdac_init(struct hibmc_drm_private *priv) }

drm_encoder_helper_add(encoder, &hibmc_encoder_helper_funcs);

• connector = devm_kzalloc(dev->dev, sizeof(*connector), GFP_KERNEL);
• if (!connector) {

• DRM_ERROR("failed to alloc memory when init connector\n");
  

and here.

.