On Wed, Jan 21, 2015 at 04:48:10PM +0530, Shobhit Kumar wrote:
For scenarios where OF is not available, we can use panel identification by name.
Signed-off-by: Shobhit Kumar shobhit.kumar@intel.com
drivers/gpu/drm/drm_panel.c | 18 ++++++++++++++++++ include/drm/drm_panel.h | 3 +++ 2 files changed, 21 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c index 2ef988e..e1cb8cf 100644 --- a/drivers/gpu/drm/drm_panel.c +++ b/drivers/gpu/drm/drm_panel.c @@ -95,6 +95,24 @@ struct drm_panel *of_drm_find_panel(struct device_node *np) EXPORT_SYMBOL(of_drm_find_panel); #endif
+struct drm_panel *drm_find_panel_by_name(const char *name) +{
- struct drm_panel *panel;
- mutex_lock(&panel_lock);
- list_for_each_entry(panel, &panel_list, list) {
if (strcmp(panel->name, name) == 0) {mutex_unlock(&panel_lock);return panel;}- }
- mutex_unlock(&panel_lock);
- return NULL;
+} +EXPORT_SYMBOL(drm_find_panel_by_name);
MODULE_AUTHOR("Thierry Reding treding@nvidia.com"); MODULE_DESCRIPTION("DRM panel infrastructure"); MODULE_LICENSE("GPL and additional rights"); diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index 1fbcc96..1ef9ff3 100644 --- a/include/drm/drm_panel.h +++ b/include/drm/drm_panel.h @@ -74,6 +74,7 @@ struct drm_panel { struct drm_device *drm; struct drm_connector *connector; struct device *dev;
- char name[NAME_MAX];
I thought I had said this before, but I can't find any record, so here goes again: NAME_MAX is a pretty large number and it increases the size of this structure a lot. Why not use dev_name(dev) to do the matching? Or if that doesn't work for some reason, allocate a string of the right size, or use a static one.
Thierry