On Wed, Oct 2, 2019 at 10:07 AM Nathan Chancellor natechancellor@gmail.com wrote:
On Wed, Oct 02, 2019 at 09:51:37AM -0700, 'Nick Desaulniers' via Clang Built Linux wrote:
Apparently this bug is still present in both the released clang-9 and the current development version of clang-10. I was hoping we would not need a workaround in clang-9+, but it seems that we do.
Here's a fix: https://reviews.llvm.org/D68356 Can't possibly land until clang-10 though.
I think I'd rather:
- mark AMDGPU BROKEN if CC_IS_CLANG. There are numerous other issues building a working driver here.
The only reason I am not thrilled about this is we will lose out on warning coverage while the compiler bug gets fixed. I think the AMDGPU drivers have been the single biggest source of clang warnings.
I think something like:
depends on CC_IS_GCC || (CC_IS_CLANG && COMPILE_TEST)
would end up avoiding the runtime issues and give us warning coverage. The only issue is that we would still need this patch...
Cheers, Nathan