Re: [PATCH] drm/stm: dsi: Use dev_ based logging

On 9/25/20 2:02 PM, Joe Perches wrote:

On Fri, 2020-09-25 at 12:22 +0200, Yannick Fertre wrote:

...

Standardize on the dev_ based logging and drop the include of drm_print.h. Remove useless dsi_color_from_mipi function.

[]

...

diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c

[]

...

• DRM_DEBUG_DRIVER("pll_in %ukHz pll_out %ukHz lane_mbps %uMHz\n",

• 	 pll_in_khz, pll_out_khz, *lane_mbps);
  

• dev_dbg(dsi->dev, "pll_in %ukHz pll_out %ukHz lane_mbps %uMHz\n", pll_in_khz, pll_out_khz,

• *lane_mbps);
  

The line wrapping change here is pretty pointless and IMO makes the code harder to read.

Hi, ok, I will restore the line wrapping.

Best regards

Yannick