Re: [PATCH v2 03/10] drm/hisilicon: Add hisilicon DRM master driver

On Sat, Nov 28, 2015 at 4:38 AM, Xinliang Liu xinliang.liu@linaro.org wrote:

Add DRM master driver for hi6220 SoC which used in HiKey board. Add dumb buffer feature. Add prime dmabuf feature.

Signed-off-by: Xinliang Liu xinliang.liu@linaro.org Signed-off-by: Xinwei Kong kong.kongxinwei@hisilicon.com Signed-off-by: Andy Green andy.green@linaro.org

---

+static int hisi_gem_cma_dumb_create(struct drm_file *file,

•                               struct drm_device *dev,
  

•                               struct drm_mode_create_dumb *args)
  

+{

•   int min_pitch = DIV_ROUND_UP(args->width * args->bpp, 8);
  

BTW, is args->bpp supposed to be bits or bytes? I'm using your dumb bo support in drm_gralloc which does bytes as that is what gralloc_drm_get_bpp returns. The virtio-gpu driver does bits. I'm guessing bits is correct.

Rob