Hi heiko and thomas,
the SPDX license identifier is updated by the following patch, please help to review, thanks.
https://patchwork.kernel.org/patch/10776935/
在 2019/1/18 下午8:34, Heiko Stuebner 写道:
Hi Thomas,
Am Freitag, 18. Januar 2019, 01:40:03 CET schrieb Thomas Gleixner:
On Thu, 30 Aug 2018, Heiko Stuebner wrote:
+++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c @@ -0,0 +1,173 @@ +//SPDX-License-Identifier: GPL-2.0+ +/*
- Copyright (C) Fuzhou Rockchip Electronics Co.Ltd
- Author:
Sandy Huang <hjc@rock-chips.com>
- This software is licensed under the terms of the GNU General Public
- License version 2, as published by the Free Software Foundation, and
- may be copied, distributed, and modified under those terms.
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
The licensing in this file and in the corresponding header is broken.
--- /dev/null +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.h @@ -0,0 +1,20 @@ +//SPDX-License-Identifier: GPL-2.0+ +/*
- Copyright (C) Fuzhou Rockchip Electronics Co.Ltd
- Author:
Sandy Huang <hjc@rock-chips.com>
- This software is licensed under the terms of the GNU General Public
- License version 2, as published by the Free Software Foundation, and
- may be copied, distributed, and modified under those terms.
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
- */
Both files use the SPDX license identifier for GPL v2 or later, but the license notice is clearly v2 only.
So the copyright holder needs to decide which one. And please remove the boiler plate text. It's redundant.
Not sure how to proceed as I haven't seen Sandy around for quite a bit, but the first versions didn't have a SPDX header and were GPL2-only (v1-v4) and the SPDX header was added in v5.
So as a stopgap measure, I'd guess we could assume that the copyright intended GPL2-only?
Please fix ASAP, add a Fixes tag and cc stable so the inconsistency is fixed in 4.20 as well.
ok, once we have the direction of change set.
Heiko