Hi,
On Thu, Feb 13, 2020 at 10:08:23PM +0200, Andrey Lebedev wrote:
On Thu, Feb 13, 2020 at 10:43:04AM +0100, Maxime Ripard wrote:
On Thu, Feb 13, 2020 at 12:23:57AM +0200, andrey.lebedev@gmail.com wrote:
From: Andrey Lebedev andrey@lebedev.lt
Define pins for LVDS channels 0 and 1, configure reset line for tcon0 and provide sample LVDS panel, connected to tcon0.
Signed-off-by: Andrey Lebedev andrey@lebedev.lt
And this prefix should be ARM: dts: sun7i ;)
Ah, thanks, I think I've got the pattern now!
/omit-if-no-ref/lcd_lvds0_pins: lcd_lvds0_pins {underscores in the node names will create a dtc warning at compilation, you should use lcd-lvds0-pins instead.
It's silenced by default, but you'll get them with W=1
You're right, I wasn't following the naming convention here. dtc doesn't produce any warning on this though. Fixed that anyway.
This will create a spurious warning message for TCON1, since we adjusted the driver to tell it supports LVDS, but there's no LVDS reset line, so we need to make it finer grained.
Yes, I can attribute two of the messages in my dmesg log [1] to this ("Missing LVDS properties" and "LVDS output disabled". "sun4i-tcon 1c0d000.lcd-controller" is indeed tcon1). And yes, I can see how they can be confusing to someone.
I'd need some pointers on how to deal with that though (if we want to do it in this scope).
Like I was mentionning, you could introduce a new compatible for each TCON (tcon0 and tcon1) and only set the support_lvds flag for tcon0
Maxime