Re: [PATCH v1 2/2] drm/panel-simple: Add missing BUS descriptions for some panels

Hi Dmitry,

Thank you for the patch.

On Mon, Jun 22, 2020 at 01:27:42AM +0300, Dmitry Osipenko wrote:

This patch adds missing BUS fields to the display panel descriptions of the panels which are found on NVIDIA Tegra devices:

1. AUO B101AW03
2. Chunghwa CLAA070WP03XG
3. Chunghwa CLAA101WA01A
4. Chunghwa CLAA101WB01
5. Innolux N156BGE L21
6. Samsung LTN101NT05

Suggested-by: Laurent Pinchart laurent.pinchart@ideasonboard.com Signed-off-by: Dmitry Osipenko digetx@gmail.com

---

drivers/gpu/drm/panel/panel-simple.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 87edd2bdf09a..986df9937650 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -698,6 +698,8 @@ static const struct panel_desc auo_b101aw03 = { .width = 223, .height = 125, },

• .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
• .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,

Does DRM_BUS_FLAG_PIXDATA_DRIVE_* make sense for LVDS ?

The rest looks good, except the Samsung panel for which I haven't been able to locate a datasheet.

Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com

.connector_type = DRM_MODE_CONNECTOR_LVDS, };

@@ -1352,6 +1354,8 @@ static const struct panel_desc chunghwa_claa070wp03xg = { .width = 94, .height = 150, },

• .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
• .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, .connector_type = DRM_MODE_CONNECTOR_LVDS,

};

@@ -1375,6 +1379,8 @@ static const struct panel_desc chunghwa_claa101wa01a = { .width = 220, .height = 120, },

• .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
• .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, .connector_type = DRM_MODE_CONNECTOR_LVDS,

};

@@ -1398,6 +1404,8 @@ static const struct panel_desc chunghwa_claa101wb01 = { .width = 223, .height = 125, },

• .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
• .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, .connector_type = DRM_MODE_CONNECTOR_LVDS,

};

@@ -2071,6 +2079,8 @@ static const struct panel_desc innolux_n156bge_l21 = { .width = 344, .height = 193, },

• .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
• .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, .connector_type = DRM_MODE_CONNECTOR_LVDS,

};

@@ -3018,6 +3028,8 @@ static const struct panel_desc samsung_ltn101nt05 = { .width = 223, .height = 125, },

• .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
• .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, .connector_type = DRM_MODE_CONNECTOR_LVDS,

};