Re: [PATCH 3/6] xf86drmMode: Make atomic request structures visible

Hi Emil,

On Thu, 20 Aug 2015 17:23:09 +0100 Emil Velikov emil.l.velikov@gmail.com wrote:

On 19 August 2015 at 01:58, Hyungwon Hwang human.hwang@samsung.com wrote:

...

This patch makes 'struct _drmModeAtomicReqItem' and 'struct _drmModeAtomicReq' visible from outside. This is needed for userspace applications to use those structures when calling drmModeAtomicCommit().

Hmmm what is missing in the current API, that one needs direct access to the structs ? If we expose these to the user we'll be putting a (ABI) hedgehog down our pants (i.e. it might be ok, but will likely result in a very painful experience).

I also agree with you. I think I should drop this patch, and find another way for modetest.

Thanks.

Best regards, Hyungwon Hwang

Thanks Emil