Re: [PATCH 1/3] drm/edid: Fix up DMT modes

On Thu, Apr 02, 2015 at 05:02:09PM +0300, ville.syrjala@linux.intel.com wrote:

From: Ville Syrjälä ville.syrjala@linux.intel.com

Liu Lei noticed that our 1856x1392@75Hz DMT mode doesn't match the spec. Fix that up, and also fix up a few other inconsistencies I discovered by parsing the spec (DMT version 1.0, revision 13) and comparing the results to our current DMT mode table.

Also clean up the indentation mess for the 1024x768i mode.

Cc: "liu,lei" lei.a.liu@intel.com Signed-off-by: Ville Syrjälä ville.syrjala@linux.intel.com

Ping. Anyone interested in DMT modes that match the spec?

---

drivers/gpu/drm/drm_edid.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 53bc7a6..567c7ed 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -160,7 +160,7 @@ static const struct drm_display_mode drm_dmt_modes[] = { DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) }, /* 640x480@60Hz */ { DRM_MODE("640x480", DRM_MODE_TYPE_DRIVER, 25175, 640, 656,

•    752, 800, 0, 480, 489, 492, 525, 0,
  

•    752, 800, 0, 480, 490, 492, 525, 0,
  

  DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC) }, /* 640x480@72Hz */ { DRM_MODE("640x480", DRM_MODE_TYPE_DRIVER, 31500, 640, 664,

@@ -206,7 +206,7 @@ static const struct drm_display_mode drm_dmt_modes[] = { { DRM_MODE("1024x768i", DRM_MODE_TYPE_DRIVER, 44900, 1024, 1032, 1208, 1264, 0, 768, 768, 772, 817, 0, DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC |

• 	DRM_MODE_FLAG_INTERLACE) },
  

•    DRM_MODE_FLAG_INTERLACE) },
  

  /* 1024x768@60Hz */ { DRM_MODE("1024x768", DRM_MODE_TYPE_DRIVER, 65000, 1024, 1048, 1184, 1344, 0, 768, 771, 777, 806, 0,

@@ -242,7 +242,7 @@ static const struct drm_display_mode drm_dmt_modes[] = { /* 1280x768@75Hz */ { DRM_MODE("1280x768", DRM_MODE_TYPE_DRIVER, 102250, 1280, 1360, 1488, 1696, 0, 768, 771, 778, 805, 0,

•    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC) },
  

•    DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
  

  /* 1280x768@85Hz */ { DRM_MODE("1280x768", DRM_MODE_TYPE_DRIVER, 117500, 1280, 1360, 1496, 1712, 0, 768, 771, 778, 809, 0,

@@ -258,7 +258,7 @@ static const struct drm_display_mode drm_dmt_modes[] = { /* 1280x800@60Hz */ { DRM_MODE("1280x800", DRM_MODE_TYPE_DRIVER, 83500, 1280, 1352, 1480, 1680, 0, 800, 803, 809, 831, 0,

•    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC) },
  

•    DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
  

  /* 1280x800@75Hz */ { DRM_MODE("1280x800", DRM_MODE_TYPE_DRIVER, 106500, 1280, 1360, 1488, 1696, 0, 800, 803, 809, 838, 0,

@@ -409,7 +409,7 @@ static const struct drm_display_mode drm_dmt_modes[] = { DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) }, /* 1856x1392@75Hz */ { DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 288000, 1856, 1984,

•    2208, 2560, 0, 1392, 1395, 1399, 1500, 0,
  

•    2208, 2560, 0, 1392, 1393, 1396, 1500, 0,
  

  DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) }, /* 1856x1392@120Hz RB */ { DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 356500, 1856, 1904,

-- 2.0.5