Hello Michal,
On 2/18/22 17:04, Michal Suchanek wrote:
Since switch to simplefb/simpledrm VESA graphic modes are no longer available with legacy BIOS.
Maybe you can mention that is the "vga=" kernel command line parameter since that may be more evident to people reading the commit message ?
The x86 realmode boot code enables the VESA graphic modes when option FB_BOOT_VESA_SUPPORT is enabled.
To enable use of VESA modes with simplefb in legacy BIOS boot mode drop
I think you meant "VESA modes with the sysfb driver" ? or something like that since otherwise it seems that you meant to use it with the simplefb (drivers/video/fbdev/simplefb.c) fbdev driver, which doesn't support the "vga=" param as far as I understand (it just uses whatever was setup).
The name sysfb_simplefb is really horrible, because it is too confusing and probably we should change it at some point...
Patch itself looks good to me though.
Reviewed-by: Javier Martinez Canillas javierm@redhat.com
Best regards,