On Fri, Mar 21, 2014 at 10:34:06AM -0400, Alex Deucher wrote:
Switch to debug only to avoid flooding the logs. This mirrors the behavior in some other drivers.
Signed-off-by: Alex Deucher alexander.deucher@amd.com Reviewed-by: Daniel Vetter daniel.vetter@ffwll.ch
Btw I've just noticed that we have a 2nd retry loop with 3 retries and a 1 msec delay which apparently is needed to kick suspended dp sinks out of their sleep. See intel_dp_dpcd_read_wake in intel_dp.c. Should we maybe move that 2nd loop into these helpers, too? -Daniel
drivers/gpu/drm/drm_dp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 35251af..74724aa 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b/drivers/gpu/drm/drm_dp_helper.c @@ -402,7 +402,7 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request, } }
- DRM_ERROR("too many retries, giving up\n");
- DRM_DEBUG_KMS("too many retries, giving up\n"); return -EIO;
}
@@ -656,7 +656,7 @@ static int drm_dp_i2c_do_msg(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg) } }
- DRM_ERROR("too many retries, giving up\n");
- DRM_DEBUG_KMS("too many retries, giving up\n"); return -EREMOTEIO;
}
-- 1.8.3.1
dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel