Re: [PATCH] drm/panel: Initialize nominal vrefresh from timings in simple panel driver

On Wed, Dec 02, 2015 at 05:45:48PM +0100, Philipp Zabel wrote:

Panel timing descriptions using struct videomode don't have the vrefresh field, so calculate it instead using drm_mode_vrefresh.

Signed-off-by: Philipp Zabel p.zabel@pengutronix.de

drivers/gpu/drm/panel/panel-simple.c | 1 + 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index f97b73e..cb7dd41 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -112,6 +112,7 @@ static int panel_simple_get_fixed_modes(struct panel_simple *panel) }

drm_display_mode_from_videomode(&vm, mode);

• mode->vrefresh = drm_mode_vrefresh(mode);
  

Is there any reason why this shouldn't be part of the drm_display_mode_from_videomode() function?

Thierry