On Tue, 14 Sep 2021, Lucas De Marchi lucas.demarchi@intel.com wrote:
On Tue, Sep 14, 2021 at 12:16:13PM +0300, Jani Nikula wrote:
On Wed, 08 Sep 2021, Lucas De Marchi lucas.demarchi@intel.com wrote:
We shouldn't be using debugfs_ namespace for this functionality. Rename debugfs_gt.[ch] to intel_gt_debugfs.[ch] and then make functions, defines and structs follow suit.
While at it and since we are renaming the header, sort the includes alphabetically.
I didn't do a detailed review, maybe someone should, but superficially seems good. On the series,
Acked-by: Jani Nikula jani.nikula@intel.com
thanks. What about the question I raised on
intel_gt_register_debugfs() vs intel_gt_debugfs_register()?
and
intel_gt_pm_register_debugfs() vs intel_gt_pm_debugfs_register()?
what would be prefered here?
Nowadays I try to juggle the function names to have the prefix match the filename. I think the driver has grown so big that we need that to help with our mental model of what goes where. Beyond that, whatever flows more naturally when you say it out aloud.
BR, Jani.