On Sat, Jun 20, 2020 at 02:17:54PM +0200, Hans de Goede wrote:
Implement the pwm_ops.get_state() method to complete the support for the new atomic PWM API.
Reviewed-by: Andy Shevchenko andriy.shevchenko@linux.intel.com Signed-off-by: Hans de Goede hdegoede@redhat.com
Changes in v3:
- Add Andy's Reviewed-by tag
- Remove extra whitespace to align some code after assignments (requested by Uwe Kleine-König)
drivers/pwm/pwm-crc.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
diff --git a/drivers/pwm/pwm-crc.c b/drivers/pwm/pwm-crc.c index 8a7f4707279c..b311354d40a3 100644 --- a/drivers/pwm/pwm-crc.c +++ b/drivers/pwm/pwm-crc.c @@ -119,8 +119,37 @@ static int crc_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, return 0; }
+static void crc_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
struct pwm_state *state)+{
- struct crystalcove_pwm *crc_pwm = to_crc_pwm(chip);
- struct device *dev = crc_pwm->chip.dev;
- unsigned int clk_div, clk_div_reg, duty_cycle_reg;
- int error;
- error = regmap_read(crc_pwm->regmap, PWM0_CLK_DIV, &clk_div_reg);
- if (error) {
dev_err(dev, "Error reading PWM0_CLK_DIV %d\n", error);return;- }
- error = regmap_read(crc_pwm->regmap, PWM0_DUTY_CYCLE, &duty_cycle_reg);
- if (error) {
dev_err(dev, "Error reading PWM0_DUTY_CYCLE %d\n", error);return;- }
- clk_div = (clk_div_reg & ~PWM_OUTPUT_ENABLE) + 1;
- state->period = clk_div * NSEC_PER_USEC * 256 / PWM_BASE_CLK_MHZ;
- state->duty_cycle = duty_cycle_reg * state->period / PWM_MAX_LEVEL;
Please round up here.
- state->polarity = PWM_POLARITY_NORMAL;
- state->enabled = !!(clk_div_reg & PWM_OUTPUT_ENABLE);
+}
Best regards Uwe