Re: [PATCH v3 03/10] drm/imx: atomic phase 1: Use transitional atomic CRTC and plane helpers

On Mon, Jul 04, 2016 at 03:40:32PM +0800, Liu Ying wrote:

Use the drm_plane_helper_update/disable() and drm_helper_crtc_mode_set() transitional atomic helpers. The crtc->mode_set_nofb callback is added so that the primary plane is no longer tied to the CRTC. Check/update logics are separated to make sure crtc->mode_set_nofb and plane->atomic_update are always successful. Also, some necessary logics are tweaked for a smooth transition.

Signed-off-by: Liu Ying gnuiyl@gmail.com

This patch causes a regression with my xorg ddx driver:

[ 29.850] (EE) armada(0): [drm] failed to set mode on crtc 24: Invalid argument

I'm not sure why (yet).