Re: [PATCH 2/2] drm/plane: Remove redundant extern

On Wed, Aug 12, 2015 at 04:54:29PM +0200, Thierry Reding wrote:

From: Thierry Reding treding@nvidia.com

Use of the extern keyword for function prototypes is unnecessary, so it can be removed.

Signed-off-by: Thierry Reding treding@nvidia.com

Applied both patches to drm-misc. -Daniel

---

include/drm/drm_plane_helper.h | 45 +++++++++++++++++++++--------------------- 1 file changed, 22 insertions(+), 23 deletions(-)

diff --git a/include/drm/drm_plane_helper.h b/include/drm/drm_plane_helper.h index 96e16283afb9..dda401bf910e 100644 --- a/include/drm/drm_plane_helper.h +++ b/include/drm/drm_plane_helper.h @@ -43,9 +43,8 @@

• planes.

*/

-extern int drm_crtc_init(struct drm_device *dev,

• 	 struct drm_crtc *crtc,
  

• 	 const struct drm_crtc_funcs *funcs);
  

+int drm_crtc_init(struct drm_device *dev, struct drm_crtc *crtc,

•   const struct drm_crtc_funcs *funcs);
  
  

/**

• drm_plane_helper_funcs - helper operations for CRTCs

@@ -79,26 +78,26 @@ static inline void drm_plane_helper_add(struct drm_plane *plane, plane->helper_private = funcs; }

-extern int drm_plane_helper_check_update(struct drm_plane *plane,

• 			 struct drm_crtc *crtc,
  

• 			 struct drm_framebuffer *fb,
  

• 			 struct drm_rect *src,
  

• 			 struct drm_rect *dest,
  

• 			 const struct drm_rect *clip,
  

• 			 int min_scale,
  

• 			 int max_scale,
  

• 			 bool can_position,
  

• 			 bool can_update_disabled,
  

• 			 bool *visible);
  

-extern int drm_primary_helper_update(struct drm_plane *plane,

• 		     struct drm_crtc *crtc,
  

• 		     struct drm_framebuffer *fb,
  

• 		     int crtc_x, int crtc_y,
  

• 		     unsigned int crtc_w, unsigned int crtc_h,
  

• 		     uint32_t src_x, uint32_t src_y,
  

• 		     uint32_t src_w, uint32_t src_h);
  

-extern int drm_primary_helper_disable(struct drm_plane *plane); -extern void drm_primary_helper_destroy(struct drm_plane *plane); +int drm_plane_helper_check_update(struct drm_plane *plane,

• 		  struct drm_crtc *crtc,
  

• 		  struct drm_framebuffer *fb,
  

• 		  struct drm_rect *src,
  

• 		  struct drm_rect *dest,
  

• 		  const struct drm_rect *clip,
  

• 		  int min_scale,
  

• 		  int max_scale,
  

• 		  bool can_position,
  

• 		  bool can_update_disabled,
  

• 		  bool *visible);
  

+int drm_primary_helper_update(struct drm_plane *plane,

• 	      struct drm_crtc *crtc,
  

• 	      struct drm_framebuffer *fb,
  

• 	      int crtc_x, int crtc_y,
  

• 	      unsigned int crtc_w, unsigned int crtc_h,
  

• 	      uint32_t src_x, uint32_t src_y,
  

• 	      uint32_t src_w, uint32_t src_h);
  

+int drm_primary_helper_disable(struct drm_plane *plane); +void drm_primary_helper_destroy(struct drm_plane *plane); extern const struct drm_plane_funcs drm_primary_helper_funcs;

int drm_plane_helper_update(struct drm_plane *plane, struct drm_crtc *crtc,

2.4.5