Re: [PATCH 1/2] drm/radeon: Use pci_dma_mapping_error()

On Wed, Apr 27, 2011 at 05:49:50PM +1000, Dave Airlie wrote:

On Wed, Apr 27, 2011 at 3:34 PM, Aurelien Jarno aurelien@aurel32.net wrote:

...

... instead of comparing with DMA_ERROR_CODE, which will only work on powerpc/sparc/x86.

So you wrote a patch that breaks it everwhere?

It seems I inverted the condition yes.

You might want to actually boot this sort of thing before I do, or read the interface for pci_dma_mapping_error, it doesn't seem to return what you seem to think it does.

I tried, but I don't have such a card, so it doesn't trigger the bug. I'll send a v2 soon.