Re: [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call

Am Donnerstag, 19. September 2013, 23:49:01 schrieb Russell King:

The DMA API requires drivers to call the appropriate dma_set_mask() functions before doing any DMA mapping. Add this required call to the AMBA PL08x driver.

^--- copy and paste error - should of course be PL330

Signed-off-by: Russell King rmk+kernel@arm.linux.org.uk

drivers/dma/pl330.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index a562d24..df8b10f 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -2903,6 +2903,10 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)

pdat = dev_get_platdata(&adev->dev);

• ret = dma_set_mask_and_coherent(&adev->dev, DMA_BIT_MASK(32));
• if (ret)

• return ret;
  

• /* Allocate a new DMAC and its Channels */ pdmac = devm_kzalloc(&adev->dev, sizeof(*pdmac), GFP_KERNEL); if (!pdmac) {