Re: [PATCH 3/6] drm/etnaviv: show identity information in debugfs

Hi Lucas,

Am Mo., 6. Jan. 2020 um 11:08 Uhr schrieb Lucas Stach l.stach@pengutronix.de:

On Do, 2020-01-02 at 11:02 +0100, Christian Gmeiner wrote:

...

Signed-off-by: Christian Gmeiner christian.gmeiner@gmail.com

drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c index 253301be9e95..cecef5034db1 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c @@ -868,6 +868,18 @@ int etnaviv_gpu_debugfs(struct etnaviv_gpu *gpu, struct seq_file *m)

  verify_dma(gpu, &debug);

• seq_puts(m, "\tidentity\n");
  

• seq_printf(m, "\t model: 0x%x\n",
  

•            gpu->identity.model);
  

• seq_printf(m, "\t revision: 0x%x\n",
  

•            gpu->identity.revision);
  

• seq_printf(m, "\t product_id: 0x%x\n",
  

•            gpu->identity.product_id);
  

• seq_printf(m, "\t customer_id: 0x%x\n",
  

•            gpu->identity.customer_id);
  

• seq_printf(m, "\t eco_id: 0x%x\n",
  

•            gpu->identity.eco_id);
  

I like having this info in debugfs. Most of those seq_printf don't need a line break though, as they fit well within the 80 char limit.

Ok..