On Mon, 5 Sep 2011 09:14:00 +0800, Wu Fengguang fengguang.wu@intel.com wrote:
On Sun, Sep 04, 2011 at 08:08:37PM +0800, Chris Wilson wrote:
On Sun, 4 Sep 2011 05:15:10 +0800, Wu Fengguang fengguang.wu@intel.com wrote: This patch should be split between adding the core drm functionality to build the ELD and the introduction of i915 support.
OK. I didn't do this because I was not sure if it's OK to just add the drm_*() functions without any code to call them..
Right, we don't introduce new interfaces without users - but it is acceptable to say "... which will be used by i915 in a following patch" if you want to clarify the need for the interface. It just helps to compartmentalize the damage should we find something goes horribly wrong later. -Chris