Thanks Felix for catching that, For some reason I remembered EOP buffer should be the same size of the queue. Then we can remove the queue size parameter from that function ?
On Mon, Nov 20, 2017 at 9:22 PM, Felix Kuehling felix.kuehling@amd.com wrote:
I think this patch is not correct. The EOP-mem is not associated with the queue size. The EOP buffer is a separate buffer used by the firmware to handle command completion. As I understand it, this allows more concurrency, while still making it look like all commands in the queue are completing in order.
Regards, Felix
On 2017-11-19 03:19 AM, Oded Gabbay wrote:
On Thu, Nov 16, 2017 at 11:36 PM, Jan Vesely jan.vesely@rutgers.edu wrote:
Signed-off-by: Jan Vesely jan.vesely@rutgers.edu
drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c b/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c index f1d48281e322..b3bee39661ab 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue_vi.c @@ -37,15 +37,16 @@ static bool initialize_vi(struct kernel_queue *kq, struct kfd_dev *dev, enum kfd_queue_type type, unsigned int queue_size) { int retval;
unsigned int size = ALIGN(queue_size, PAGE_SIZE);
retval = kfd_gtt_sa_allocate(dev, PAGE_SIZE, &kq->eop_mem);
retval = kfd_gtt_sa_allocate(dev, size, &kq->eop_mem); if (retval != 0) return false; kq->eop_gpu_addr = kq->eop_mem->gpu_addr; kq->eop_kernel_addr = kq->eop_mem->cpu_ptr;
memset(kq->eop_kernel_addr, 0, PAGE_SIZE);
memset(kq->eop_kernel_addr, 0, size); return true;}
2.13.6
amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Thanks! Applied to -next tree Oded _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx