Re: [PATCH 06/13] drm/mgag200: Remove unecessary NULL check in gem_free

On 04/05/2014 02:44 AM, Daniel Vetter wrote:

The ->gem_free_object never gets called with a NULL pointer, the check is redundant. Also checking after the upcast allows compilers to elide it anyway.

Spotted by coverity.

Signed-off-by: Daniel Vetter daniel.vetter@ffwll.ch

Same as MGA change.

Reviewed-by: Ian Romanick ian.d.romanick@intel.com

---

drivers/gpu/drm/ast/ast_main.c | 2 -- 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c index 38941a656312..01bf9e730acf 100644 --- a/drivers/gpu/drm/ast/ast_main.c +++ b/drivers/gpu/drm/ast/ast_main.c @@ -418,8 +418,6 @@ void ast_gem_free_object(struct drm_gem_object *obj) { struct ast_bo *ast_bo = gem_to_ast_bo(obj);

• if (!ast_bo)

• return;
  

  ast_bo_unref(&ast_bo);

}