(In reply to Alex Deucher from comment #59) > I also noticed a minor error in the RPM control setup, and I've pushed a > patch to my 3.19-wip branch. I (think I) found another typo, that was tricky one to notice :D > tmp = RREG32_SMC(CG_FDO_CTRL2) & FDO_PWM_MODE_MASK; > tmp |= FDO_PWM_MODE(mode); > WREG32_SMC(CG_FDO_CTRL2, tmp); bitwise not (~) is missing from the first line