Re: [Intel-gfx] [PATCH 3/3] drm/mm: WARN for unclean mm takedown

On Mon, 1 Jul 2013 22:01:04 +0200 Daniel Vetter daniel.vetter@ffwll.ch wrote:

The usual drm driver has tons of different drm_mm memory managers so the drm error message in dmesg is pretty useless. WARN instead so that we have the full backtrace.

Signed-off-by: Daniel Vetter daniel.vetter@ffwll.ch

I've written this patch myself a number of times. Reviewed-by: Ben Widawsky ben@bwidawsk.net

---

drivers/gpu/drm/drm_mm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index f9d4873..d303e31 100644 --- a/drivers/gpu/drm/drm_mm.c +++ b/drivers/gpu/drm/drm_mm.c @@ -699,8 +699,8 @@ void drm_mm_takedown(struct drm_mm * mm) { struct drm_mm_node *entry, *next;

• if (!list_empty(&mm->head_node.node_list)) {

• DRM_ERROR("Memory manager not clean. Delaying
  

takedown\n");

• if (WARN(!list_empty(&mm->head_node.node_list),

•  "Memory manager not clean. Delaying takedown\n")) {
  

  return; }