On 3/9/22 13:56, Geert Uytterhoeven wrote:
On Wed, Mar 9, 2022 at 2:57 AM Chen-Yu Tsai wens@kernel.org wrote:
From: Chen-Yu Tsai wens@csie.org
The SSD130x's command to toggle COM scan direction uses bit 3 and only bit 3 to set the direction of the scanout. The driver has an incorrect GENMASK(3, 2), causing the setting to be set on bit 2, rendering it ineffective.
Fix the mask to only bit 3, so that the requested setting is applied correctly.
Fixes: a61732e80867 ("drm: Add driver for Solomon SSD130x OLED displays") Signed-off-by: Chen-Yu Tsai wens@csie.org
Thanks, this fixes the vertically-mirrored display on my Adafruit FeatherWing 128x32 OLED. Tested-by: Geert Uytterhoeven geert@linux-m68k.org Reviewed-by: Geert Uytterhoeven geert@linux-m68k.org
Thanks for the testing and review. I've pushed both patches to drm-misc-next.