Re: [PATCH v4 00/17] drm: add gem ttm helpers, rework mmap workflow.

On Tue, Aug 27, 2019 at 07:13:41AM +0200, Gerd Hoffmann wrote:

Hi,

...

Also this patch series also adjust vram helpers, and I think it has a slightly different goal: Just aligning mmap paths a bit more between ttm and not-ttm based drivers.

Not just ttm/not-ttm. gem_driver->fops->mmap is the only fops callback where we can't use a generic gem callback today. This series tries to fix that with the new drm_gem_object_funcs->mmap hook, so the mmap() code path isn't the odd one which works different than every other drm_gem_object operation.

...

Seems like a good goal, details might need adjustment.

Which details?

Just a general comment that the tricky parts are always in the details ... -Daniel