Re: [PATCH v2] drm/radeon: Fix NULL dereference when updating memory stats

On Wednesday, June 23, 2021 2:55:04 AM EDT Christian König wrote:

Please rather keep the new resource as parameter here and update before adjusting bo->resource.

This way you also don't need to export radeon_update_memory_usage().

I wasn't sure exactly what you intended with the request to "update before adjusting bo->resource".

Assuming the statistics update is done as part of radeon_bo_move_notify(), I believe that function cannot be called any earlier in radeon_bo_move(). If it were, the source object would be invalidated before it moved.

So I assume you're suggesting updating the memory usage earlier in bo_move_notify (before the early return for ghost objects).

Thanks, Mikel