Re: [PATCH 11/14] drm/msm: Add support for iommu-sva PASIDs

On 21/02/18 22:59, Jordan Crouse wrote: [...]> +static int install_pasid_cb(int pasid, u64 ttbr, u32 asid, void *data)

+{

• struct pasid_entry *entry = kzalloc(sizeof(*entry), GFP_KERNEL);
• if (!entry)

• return -ENOMEM;
  

• entry->pasid = pasid;
• entry->ttbr = ttbr;
• entry->asid = asid;
• /* FIXME: Assume that we'll never have a pasid conflict? */

I think a conflict would be a bug on the IOMMU side. Users should not have to check this. Then again, I have a few WARNs on the SMMUv3 context table code that uncovered nasty bugs during development.

Thanks, Jean