On Wed, Jan 05, 2022 at 12:04:34PM +0100, Oleksij Rempel wrote:
Hi Shawn,
sorry for the delay, I just came back to work.
On Mon, Dec 06, 2021 at 09:06:28AM +0800, Shawn Guo wrote:
On Mon, Nov 22, 2021 at 01:43:10PM +0100, Oleksij Rempel wrote:
The tsc2046 is an ADC used as touchscreen controller. To share as mach code as possible, we should use it as actual ADC + virtual tochscreen controller. With this patch we make use of the new kernel IIO and HID infrastructure.
Signed-off-by: Oleksij Rempel o.rempel@pengutronix.de
One space is enough in subject "victgo: make".
done.
arch/arm/boot/dts/imx6dl-plym2m.dts | 55 ++++++++++++++++++++--------- arch/arm/boot/dts/imx6dl-prtvt7.dts | 53 ++++++++++++++++++++------- arch/arm/boot/dts/imx6dl-victgo.dts | 55 +++++++++++++++++++++-------- 3 files changed, 120 insertions(+), 43 deletions(-)
diff --git a/arch/arm/boot/dts/imx6dl-plym2m.dts b/arch/arm/boot/dts/imx6dl-plym2m.dts index 60fe5f14666e..e2afedae85cb 100644 --- a/arch/arm/boot/dts/imx6dl-plym2m.dts +++ b/arch/arm/boot/dts/imx6dl-plym2m.dts @@ -101,6 +101,17 @@ reg_12v0: regulator-12v0 { regulator-min-microvolt = <12000000>; regulator-max-microvolt = <12000000>; };
- touchscreen {
compatible = "resistive-adc-touch";io-channels = <&adc 1>, <&adc 3>, <&adc 4>, <&adc 5>;io-channel-names = "y", "z1", "z2", "x";touchscreen-min-pressure = <64687>;touchscreen-inverted-x;touchscreen-inverted-y;touchscreen-x-plate-ohms = <300>;touchscreen-y-plate-ohms = <800>;- };
};
&can1 { @@ -129,26 +140,38 @@ &ecspi2 { pinctrl-0 = <&pinctrl_ecspi2>; status = "okay";
- touchscreen@0 {
compatible = "ti,tsc2046";
- adc: adc@0 {
Isn't label name "adc" too generic?
I do not have strong opinion about this. Currently we have no restrictions for the node names: Documentation/devicetree/bindings/iio/adc/ti,tsc2046.yaml Documentation/devicetree/bindings/iio/adc/adc.yaml
I can name it touchscreen-adc@0 or something like this. What are your preferences?
I wasn't talking about node name but label.
Shawn