Quoting Abhinav Kumar (2022-04-11 17:29:17)
On 4/11/2022 5:22 PM, Dmitry Baryshkov wrote:
On 12/04/2022 03:21, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-04-11 17:08:49)
- kthread_run(hpd_event_thread, dp_priv, "dp_hpd_handler"); + dp_priv->ev_tsk = kthread_run(hpd_event_thread, dp_priv, "dp_hpd_handler");
+ if (IS_ERR(dp_priv->ev_tsk)) + DRM_ERROR("failed to create DP event thread\n");
Why can't we error out? Why can't this kthread be started in probe?
Just my 2c. I don't think starting it in probe is a good idea. The driver uses components, so, in my opinion, the thread should be started from bind and stopped in unbind.
Yes, I also agree it should be started in bind and stopped in unbind.
Sounds good to me! I forgot that this is a component.