Re: [PATCH 11/18] iommu/fsl_pamu: remove the snoop_id field

On Tue, Mar 16, 2021 at 04:38:17PM +0100, Christoph Hellwig wrote:

The snoop_id is always set to ~(u32)0.

Signed-off-by: Christoph Hellwig hch@lst.de Acked-by: Li Yang leoyang.li@nxp.com

---

drivers/iommu/fsl_pamu_domain.c | 5 ++--- drivers/iommu/fsl_pamu_domain.h | 1 - 2 files changed, 2 insertions(+), 4 deletions(-)

pamu_config_ppaace() takes quite a few useless parameters at this stage, but anyway:

Acked-by: Will Deacon will@kernel.org

Do you know if this driver is actually useful? Once the complexity has been stripped back, the stubs and default values really stand out.

Will