On Wed, Aug 28, 2013 at 03:41:35PM +0300, Mikko Perttunen wrote:
On 08/28/2013 03:25 PM, Thierry Reding wrote:
[...]
Signed-off-by: Mikko Perttunen mperttunen@nvidia.com
arch/arm/boot/dts/tegra114.dtsi | 43 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+)
diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi index 2905145..ce5a95c 100644 --- a/arch/arm/boot/dts/tegra114.dtsi +++ b/arch/arm/boot/dts/tegra114.dtsi @@ -27,6 +27,49 @@ (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>; };
- host1x {
compatible = "nvidia,tegra114-host1x", "nvidia,tegra30-host1x",I don't think that's correct. The Tegra114 host1x is not backwards compatible with the Tegra30 host1x.
That said, I have a local patch that is a bit more complete in that it adds other host1x devices as listed in the TRM as well. But I'll leave it up to Stephen how he prefers to handle that. It should be fine to defer adding nodes for additional hardware blocks when the supporting drivers are merged. We've done it for other devices as well.
Ok. Will need to add tegra114-host1x to the host1x driver compat strings, then, but I guess that's better than having it wrong in the DT.
I think that's not all. I have local patches that also introduce a v2 of host1x, because the number of syncpoints is different. There may also be other differences, but Terje might be more qualified to answer that.
hdmi {compatible = "nvidia,tegra114-hdmi";reg = <0x54280000 0x00040000>;interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;clocks = <&tegra_car TEGRA114_CLK_HDMI>,<&tegra_car TEGRA114_CLK_PLL_D_OUT0>;Any reason why we can't use pll_d2_out0 here, like we do on Tegra30?
I have this set to PLL_D because I don't have panel support so disp1 will be the HDMI DC. However, it doesn't seem to matter which one is specified here. I have also tested HDMI with disp2 and that works too.
Well eventually we'll add panel support and I think it'd be good to stay consistent as to what clocks are used for the internal and external displays.
Thierry