Re: [PATCH] drm/omap: Depend on CONFIG_OF

On Thu, Aug 5, 2021 at 5:07 PM Peter Stuge peter@stuge.se wrote:

Laurent Pinchart wrote:

...

+++ b/drivers/gpu/drm/omapdrm/Kconfig @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config DRM_OMAP tristate "OMAP DRM"

• depends on DRM
  

• depends on DRM && OF
  depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM
  select OMAP2_DSS
  select DRM_KMS_HELPER
  

Would it make sense to select OF instead?

select is extremely harmful for any user-visible symbols or symbols with dependencies. So no, not a good idea. -Daniel