On Mon, Jan 04, 2016 at 11:45:05AM -0500, Alex Deucher wrote:
On Mon, Jan 4, 2016 at 10:44 AM, Thierry Reding thierry.reding@gmail.com wrote:
From: Thierry Reding treding@nvidia.com
Commit 88e72717c2de ("drm/irq: Use unsigned int pipe in public API") updated the prototype of this function but not the implementation. This wasn't noticed even through compile tests because the prototype is part of the source file that uses it and hence the compiler won't know the prototype when it compiles the implementation.
The right thing would've been to move the prototype to a header that's included in radeon_kms.c so that the implementation signature could be checked against it, but the closest thing would've been radeon_drv.h and including that results in a lot of build errors, so we'll leave it as is for now.
Cc: Christian König christian.koenig@amd.com Cc: Alex Deucher alexander.deucher@amd.com Signed-off-by: Thierry Reding treding@nvidia.com
Changes in v2:
- remove unnecessary check for unsigned int < 0
I had applied your previous patch before Michel's feedback so it's already in drm-next, any change you could spin a new patch to just drop the < 0 check?
Done.
Thierry