Re: [PATCHv5 04/11] exynos_hdmi: add CEC notifier support

On Wed, Mar 29, 2017 at 04:15:36PM +0200, Hans Verkuil wrote:

• cec_notifier_set_phys_addr(hdata->notifier,

• 		   cec_get_edid_phys_addr(edid));
  

This pattern causes problems - can we have the notifier taking the EDID please, and stubs in cec-notifier.h to stub that out?

Maybe something like cec_notifier_set_phys_addr_from_edid(edid) ?

Having converted the tda998x code over to your new notifier, the 0-day builder reported this tonight:

...

ERROR: "cec_get_edid_phys_addr" [drivers/gpu/drm/i2c/tda998x.ko] undefined!

which is caused exactly by this problem. I can add #ifdefs into the tda998x driver, but as you're already stubbing out cec_notifier_set_phys_addr() in cec-notifier.h, it would be stupid to have to resort to #ifdefs in driver code to solve this issue.

Thanks.