On Fri, Nov 11, 2011 at 10:47 AM, Dave Airlie airlied@gmail.com wrote:
On Tue, Nov 8, 2011 at 9:18 PM, Jesse Barnes jbarnes@virtuousgeek.org wrote:
To properly support the various plane formats supported by different hardware, the kernel must know the pixel format of a framebuffer object. So add a new ioctl taking a format argument corresponding to a fourcc name from videodev2.h. Implement the fb creation hooks in terms of the new mode_fb_cmd2 using helpers where the old bpp/depth values are needed.
I'm nearly sure I said this before, but please move the FOURCC defines somewhere generic, then use those, otherwise this is going to encourage crappy userspace coding where they drag in libv4l2 just to use a drm feature.
I know they are generic, but userspace writes will start to include v4l headers to get at the same defines you use in the kernel.
Oh and I'll take it as a follow-up patch. as I'd rather merge the base code now before it gets too late.
Dave.