Hi, Daniel:
On Fri, 2019-12-13 at 18:26 +0100, Daniel Vetter wrote:
Checking both is one too much, so wrap a WARN_ON around it to stope the copypasta.
Even though I don't know what is copypasta,
Acked-by: CK Hu ck.hu@mediatek.com
Signed-off-by: Daniel Vetter daniel.vetter@intel.com Cc: CK Hu ck.hu@mediatek.com Cc: Philipp Zabel p.zabel@pengutronix.de Cc: Matthias Brugger matthias.bgg@gmail.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org
drivers/gpu/drm/mediatek/mtk_drm_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c index 540ef2faa40a..f0b0325381e0 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c @@ -94,7 +94,7 @@ static int mtk_plane_atomic_check(struct drm_plane *plane, if (!fb) return 0;
- if (!state->crtc)
if (WARN_ON(!state->crtc)) return 0;
ret = mtk_drm_crtc_plane_check(state->crtc, plane,