Re: [PATCH v2 2/5] dt-bindings: mediatek: display: Change format to yaml

Hi, Jason:

jason-jh.lin jason-jh.lin@mediatek.com 於 2021年7月29日 週四 下午11:49寫道：

Change mediatek,dislpay.txt to mediatek,display.yaml

Signed-off-by: jason-jh.lin jason-jh.lin@mediatek.com

.../display/mediatek/mediatek,disp.txt | 219 --------- .../display/mediatek/mediatek,disp.yaml | 432 ++++++++++++++++++ 2 files changed, 432 insertions(+), 219 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,disp.yaml

[snip]

• DISP function blocks
• ====================
• A display stream starts at a source function block that reads pixel data from
• memory and ends with a sink function block that drives pixels on a display
• interface, or writes pixels back to memory. All DISP function blocks have
• their own register space, interrupt, and clock gate. The blocks that can
• access memory additionally have to list the IOMMU and local arbiter they are
• connected to.

+properties:

• compatible:
• description: |

•  If the display function block of different soc have the same function,
  

•  you can use the same compatible name after it.
  

•  For example, if mt8183 COLOR function is the same as mt8173, then the
  

•  compatible of mt8183 cholud be set as:
  

•  compatible = "mediatek,mt8183-disp-color", "mediatek,mt8173-disp-color";
  

• oneOf:

•  # OVL: overlay (4 layers, blending, csc)
  

•  - items:
  

•      - const: mediatek,mt2701-disp-ovl
  

•  - items:
  

•      - const: mediatek,mt8173-disp-ovl
  

•  - items:
  

•      - const: mediatek,mt8183-disp-ovl
  

•  - items:
  

•      - enum:
  

•          - mediatek,mt7623-disp-ovl
  

•          - mediatek,mt2712-disp-ovl
  

•      - enum:
  

•          - mediatek,mt2701-disp-ovl
  

•  - items:
  

•      - enum:
  

•          - mediatek,mt8192-disp-ovl
  

•      - enum:
  

•          - mediatek,mt8183-disp-ovl
  

•  # OVL2L: overlay (2 layers, blending, csc)
  

•  - items:
  

•      - const: mediatek,mt8183-disp-ovl-2l
  

•  - items:
  

•      - enum:
  

•          - mediatek,mt8192-disp-ovl-2l
  

•      - enum:
  

•          - mediatek,mt8183-disp-ovl-2l
  

•  # RDMA: read DMA / line buffer
  

•  - items:
  

•      - const: mediatek,mt2701-disp-rdma
  

•  - items:
  

•      - const: mediatek,mt8173-disp-rdma
  

•  - items:
  

•      - const: mediatek,mt8183-disp-rdma
  

•  - items:
  

•      - enum:
  

•          - mediatek,mt7623-disp-rdma
  

•          - mediatek,mt2712-disp-rdma
  

•      - enum:
  

•          - mediatek,mt2701-disp-rdma
  

•  - items:
  

•      - enum:
  

•          - mediatek,mt8192-disp-rdma
  

•      - enum:
  

•          - mediatek,mt8183-disp-rdma
  

•  # WDMA: write DMA
  

•  - items:
  

•      - const: mediatek,mt8173-disp-wdma
  

•  # CCORR: color correction
  

•  - items:
  

•      - const: mediatek,mt8183-disp-ccorr
  

•  - items:
  

•      - enum:
  

•          - mediatek,mt8192-disp-ccorr
  

•      - enum:
  

•          - mediatek,mt8183-disp-ccorr
  

•  # COLOR: color processor
  

•  - items:
  

•      - const: mediatek,mt2701-disp-color
  

•  - items:
  

•      - const: mediatek,mt8167-disp-color
  

•  - items:
  

•      - const: mediatek,mt8173-disp-color
  

•  - items:
  

•      - enum:
  

•          - mediatek,mt7623-disp-color
  

•          - mediatek,mt2712-disp-color
  

•      - enum:
  

•          - mediatek,mt2701-disp-color
  

•  - items:
  

•      - enum:
  

•          - mediatek,mt8183-disp-color
  

•          - mediatek,mt8192-disp-color
  

•      - enum:
  

•          - mediatek,mt8173-disp-color
  

•  # DITHER
  

•  - items:
  

•      - const: mediatek,mt8183-disp-dither
  

•  - items:
  

•      - enum:
  

•          - mediatek,mt8192-disp-dither
  

•      - enum:
  

•          - mediatek,mt8183-disp-dither
  

•  # AAL: adaptive ambient light controller
  

•  - items:
  

•      - const: mediatek,mt8173-disp-aal
  

•  - items:
  

•      - enum:
  

•          - mediatek,mt2712-disp-aal
  

•          - mediatek,mt8183-disp-aal
  

•          - mediatek,mt8192-disp-aal
  

•      - enum:
  

•          - mediatek,mt8173-disp-aal
  

•  # GAMMA: gamma correction
  

•  - items:
  

•      - const: mediatek,mt8173-disp-gamma
  

•  - items:
  

•      - const: mediatek,mt8183-disp-gamma
  

•  - items:
  

•      - enum:
  

•          - mediatek,mt8192-disp-gamma
  

•      - enum:
  

•          - mediatek,mt8183-disp-gamma
  

•  # MERGE: merge streams from two RDMA sources
  

•  # POSTMASK: control round corner for display frame
  

•  - items:
  

•      - const: mediatek,mt8192-disp-postmask
  

•  # SPLIT: split stream to two encoders
  

•  # UFOE: data compression engine
  

•  - items:
  

•      - const: mediatek,mt8173-disp-ufoe
  

•  # DSI: see Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt for details.
  

•  - items:
  

•      - const: mediatek,mt2701-disp-dsi
  

•  - items:
  

•      - const: mediatek,mt8173-disp-dsi
  

•  - items:
  

•      - const: mediatek,mt8183-disp-dsi
  

•  - items:
  

•      - enum:
  

•          - mediatek,mt7623-disp-dsi
  

•          - mediatek,mt2712-disp-dsi
  

•      - enum:
  

•          - mediatek,mt2701-disp-dsi
  

•  - items:
  

•      - enum:
  

•          - mediatek,mt8192-disp-dsi
  

•      - enum:
  

•          - mediatek,mt8183-disp-dsi
  

•  # DPI: see Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml for details.
  

•  - items:
  

•      - const: mediatek,mt2701-disp-dpi
  

•  - items:
  

•      - const: mediatek,mt8173-disp-dpi
  

•  - items:
  

•      - const: mediatek,mt8183-disp-dpi
  

•  - items:
  

•      - const: mediatek,mt8192-disp-dpi
  

•  - items:
  

•      - enum:
  

•          - mediatek,mt7623-disp-dpi
  

•          - mediatek,mt2712-disp-dpi
  

•      - enum:
  

•          - mediatek,mt2701-disp-dpi
  

•  # MUTEX: display mutex
  

•  - items:
  

•      - const: mediatek,mt2701-disp-mutex
  

•  - items:
  

•      - const: mediatek,mt2712-disp-mutex
  

•  - items:
  

•      - const: mediatek,mt8167-disp-mutex
  

•  - items:
  

•      - const: mediatek,mt8173-disp-mutex
  

•  - items:
  

•      - const: mediatek,mt8183-disp-mutex
  

•  - items:
  

•      - const: mediatek,mt8192-disp-mutex
  

•  # OD: overdrive
  

•  - items:
  

•      - const: mediatek,mt2712-disp-od
  

•  - items:
  

•      - const: mediatek,mt8173-disp-od
  

I think you should follow Rob's suggestion [1] to split each function block into one schema.

[1] https://patchwork.kernel.org/project/linux-mediatek/patch/20210715173750.108...

Regards, Chun-Kuang.