Re: [PATCH v6 02/13] dt-bindings: panel: Convert rocktech,jh057n00900 to yaml

Hello Guido,

On Wed, Jul 01, 2020 at 05:58:57PM +0200, Guido Günther wrote:

Hi Ondrej, On Wed, Jul 01, 2020 at 12:31:15PM +0200, Ondrej Jirman wrote:

...

Convert Rocktech MIPI DSI panel driver from txt to yaml bindings.

Signed-off-by: Ondrej Jirman megous@megous.com

.../display/panel/rocktech,jh057n00900.txt | 23 ------- .../display/panel/rocktech,jh057n00900.yaml | 66 +++++++++++++++++++ 2 files changed, 66 insertions(+), 23 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt create mode 100644 Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml

Thanks for the conversion! Shouldn't we switch to `sitronix-st7703.yaml` as well in this patch?

Names of yaml files should be according to one of the compatibles.

And thank you for your review of the patches.

regards, o.

Cheers, -- Guido

...

diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt deleted file mode 100644 index a372c5d84695..000000000000 --- a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt +++ /dev/null @@ -1,23 +0,0 @@ -Rocktech jh057n00900 5.5" 720x1440 TFT LCD panel

-Required properties: -- compatible: should be "rocktech,jh057n00900" -- reg: DSI virtual channel of the peripheral -- reset-gpios: panel reset gpio -- backlight: phandle of the backlight device attached to the panel -- vcc-supply: phandle of the regulator that provides the vcc supply voltage. -- iovcc-supply: phandle of the regulator that provides the iovcc supply

• voltage.

-Example:

• &mipi_dsi {

• panel@0 {
  

• 	compatible = "rocktech,jh057n00900";
  

• 	reg = <0>;
  

• 	backlight = <&backlight>;
  

• 	reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
  

• 	vcc-supply = <&reg_2v8_p>;
  

• 	iovcc-supply = <&reg_1v8_p>;
  

• };
  

• };

diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml new file mode 100644 index 000000000000..928ba42e7f8d --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml @@ -0,0 +1,66 @@ +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/rocktech,jh057n00900.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Rocktech JH057N00900 5.5" 720x1440 TFT LCD panel

+maintainers:

• • Ondrej Jirman megi@xff.cz

+description: |

•         Rocktech JH057N00900 is a 720x1440 TFT LCD panel
  

•         connected using a MIPI-DSI video interface.
  

+allOf:

• • $ref: panel-common.yaml#

+properties:

• compatible:
• const: rocktech,jh057n00900
• reg:
• maxItems: 1
• description: DSI virtual channel
• vcc-supply:
• description: Panel power supply
• iovcc-supply:
• description: I/O voltage supply
• reset-gpios:
• description: GPIO used for the reset pin
• maxItems: 1
• backlight:
• description: Backlight used by the panel
• $ref: "/schemas/types.yaml#/definitions/phandle"

+required:

• • compatible
• • reg
• • vcc-supply
• • iovcc-supply
• • reset-gpios

+additionalProperties: false

+examples:

• • |
• #include <dt-bindings/gpio/gpio.h>
• dsi {

•  #address-cells = <1>;
  

•  #size-cells = <0>;
  

•  panel@0 {
  

•    compatible = "rocktech,jh057n00900";
  

•    reg = <0>;
  

•    vcc-supply = <&reg_2v8_p>;
  

•    iovcc-supply = <&reg_1v8_p>;
  

•    reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
  

•    backlight = <&backlight>;
  

•  };
  

• };

+...

2.27.0