Re: [Intel-gfx] [PATCH] drm/i915: Kconfig option to disable the legacy fbdev support

On Wed, Oct 09, 2013 at 09:18:51AM +0200, Daniel Vetter wrote:

mode_fits_in_fbdev(struct drm_device *dev, struct drm_display_mode *mode) { +#ifdef CONFIG_DRM_I915_FBDEV struct drm_i915_private *dev_priv = dev->dev_private; struct drm_i915_gem_object *obj; struct drm_framebuffer *fb; @@ -7338,6 +7339,9 @@ mode_fits_in_fbdev(struct drm_device *dev, return NULL;

return fb; +#else

• return NULL;

+#endif

This for example is not fbdev specific. There used to be code, extracted from this function, to sanity check that the mode fitted in the fb provided by the user and by the bios. Which caught a few problems in the past. -Chris