On Thu, Aug 23, 2018 at 07:56:12PM -0700, Kees Cook wrote:
On Thu, Aug 23, 2018 at 6:05 PM, Gustavo A. R. Silva gustavo@embeddedor.com wrote:
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct foo { int stuff; void *entry[]; };
instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can now use the new struct_size() helper:
instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva gustavo@embeddedor.com
Reviewed-by: Kees Cook keescook@chromium.org
Applied, thanks! Maxime