On Mon, Nov 11, 2013 at 11:58:59AM -0800, Eric Anholt wrote:
Ian Romanick idr@freedesktop.org writes:
From: Ian Romanick ian.d.romanick@intel.com
The drm_intel_context structure is, wisely, opaque. However, libdrm users may want to know the hardware context ID associated with the structure.
We've had a bunch of our other structures be partially transparent. The context id to be passed to the kernel could easily be public just like the gem handle in a BO is public. I would lean slightly toward that.
But I don't feel strongly either way, so these two are:
Reviewed-by: Eric Anholt eric@anholt.net
I think my preference would be to add a "context" argument to a libdrm get_hangstats function, but if you feel this way is better, it is fine with me.
My only [slight, unjustified] concern is that once you make the id transparent, we can't play any games. Since the DDX doesn't use libdrm however, I think it is fairly moot.
Acked-by: Ben Widawsky ben@bwidawsk.net