[AMD Public Use]
Reviewed-by: Wayne Lin Wayne.Lin@amd.com
Thanks!
-----Original Message----- From: Lyude Paul lyude@redhat.com Sent: Thursday, January 23, 2020 3:49 AM To: dri-devel@lists.freedesktop.org Cc: Lin, Wayne Wayne.Lin@amd.com; Maarten Lankhorst maarten.lankhorst@linux.intel.com; Maxime Ripard mripard@kernel.org; David Airlie airlied@linux.ie; Daniel Vetter daniel@ffwll.ch; linux-kernel@vger.kernel.org Subject: [PATCH] drm/dp_mst: Convert drm_dp_mst_topology_mgr.is_waiting_for_dwn_reply to bitfield
Small nitpick that I noticed a second ago - we can save some space in the struct by making this a bitfield and sticking it with the rest of the bitfields. Also, some small cleanup to the kdocs for this member.
There should be no functional changes in this patch.
Signed-off-by: Lyude Paul lyude@redhat.com Cc: Wayne Lin Wayne.Lin@amd.com
include/drm/drm_dp_mst_helper.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_helper.h index bcb39da9adb4..58bbab3684b5 100644 --- a/include/drm/drm_dp_mst_helper.h +++ b/include/drm/drm_dp_mst_helper.h @@ -590,6 +590,11 @@ struct drm_dp_mst_topology_mgr { */ bool payload_id_table_cleared : 1;
- /**
* @is_waiting_for_dwn_reply: whether we're waiting for a down reply.*/- bool is_waiting_for_dwn_reply : 1;
- /**
*/
- @mst_primary: Pointer to the primary/first branch device.
@@ -619,11 +624,6 @@ struct drm_dp_mst_topology_mgr { */ struct mutex qlock;
- /**
* @is_waiting_for_dwn_reply: indicate whether is waiting for downreply
*/- bool is_waiting_for_dwn_reply;
- /**
*/
- @tx_msg_downq: List of pending down replies.
-- 2.24.1