On Fri, Sep 25, 2020 at 03:25:51PM +0200, Daniel Vetter wrote:
I think the only way to make this work is that we have one place which takes in the userspace uapi struct, and then converts it once into a kernel_console_font. With all the error checking.
Ah, I didn't think of that! When trying to introduce `kernel_console_font` I ended up using the uapi version and the kernel version in parallel...
Then all internal code deals in terms of kernel_console_font, with properly typed and named struct members and helper functions and everything. And we might need a gradual conversion for this, so that first we can convert over invidual console drivers, then subsystems, until at the end we've pushed the conversion from uapi array to kernel_console_font all the way to the ioctl entry points.
But that's indeed a huge pile of work, and fair warning: fbcon is semi-orphaned, so by doing this you'll pretty much volunteer for maintainership :-)
But I'd be very happy to help get this done and throw some maintainership credentials at you in the proces ...
Sounds exciting, I will be glad to do this! I'm just a beginner, but I will try to do what I can do.
Thank you, Peilin Ye