On 21.12.2012 16:36, Thierry Reding wrote:
On Fri, Dec 21, 2012 at 01:39:21PM +0200, Terje Bergstrom wrote:
+static void tegra_drm_close(struct drm_device *drm, struct drm_file *filp) +{
+}
This can be removed, right?
Yes, done.
+static struct platform_driver tegra_drm_platform_driver = {
- .driver = {
.name = "tegradrm",This should be "tegra-drm" to match the module name.
Done.
-struct host1x_client; +struct tegra_drm_client;
I don't see the point in renaming this. All of the devices are still host1x clients, right? This patch would be a whole shorter if we didn't rename these. None of these symbols are exported either so there's not much chance for them to clash with anything.
Yep, we renamed it back to make the patch smaller.
diff --git a/include/drm/tegra_drm.h b/include/drm/tegra_drm.h new file mode 100644 index 0000000..8632f49 --- /dev/null +++ b/include/drm/tegra_drm.h @@ -0,0 +1,20 @@ +/*
- Copyright (c) 2012, NVIDIA CORPORATION. All rights reserved.
- This program is free software; you can redistribute it and/or modify it
- under the terms and conditions of the GNU General Public License,
- version 2, as published by the Free Software Foundation.
- This program is distributed in the hope it will be useful, but WITHOUT
- ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
- more details.
- You should have received a copy of the GNU General Public License
- along with this program. If not, see http://www.gnu.org/licenses/.
- */
+#ifndef _TEGRA_DRM_H_ +#define _TEGRA_DRM_H_
+#endif
This can be removed as well.
Removed.
I posted another proposal on how to handle initialization in tegradrm. It removes a lot of code and relies more on platform_bus keeping track of devices. Have you had time to look into it?
Terje