Wiadomość napisana przez Sascha Hauer s.hauer@pengutronix.de w dniu 21.01.2022, o godz. 11:32:
- how support for CEC looks/prospects (plans for future, not in this code, expecting others should implement, etc)?
I had to google what CEC actually is. We don't have plans supporting it. It looks like this is a matter of the HDMI driver supporting this and not bound to the rockchip driver.
Ah ok. sure. got it! (I asked as Rockchip hdmi driver already well supports CEC - so i was thinking on rk3566 this is more of enabling than writing support code).
You enabled the panfrost driver with other patches, right?
Oh - i wasn't aware any patches are needed for Mesa for rk3566.... If so - may you pls point me for latest/correct patches for rk3566?
- in kernel dmesg I have many:
"rockchip-drm display-subsystem: [drm] *ERROR* Unsupported format modifier 0x810000000000001".
This message is correct. This corresponds to DRM_FORMAT_MOD_ARM_16X16_BLOCK_U_INTERLEAVED and the VOP2 driver doesn't support this. I have a similar problem here with weston-simple-dmabuf-egl. By default this uses DRM_FORMAT_XRGB8888 which ends up being PIPE_FORMAT_B8G8R8_UNORM in MESA.
Ah ok. Clear now.
Thx!
btw: i added support for argb8888 in my app and now all is ok. no anymore errors in dmesg :-)
so summarising: your vop2 code works for me in all supported video pipeline variants:
-x11/Glamour -Wayland-EGL -EGLFS/EGL-dmabuf -EGLFS/DRM Planes
Your vop2 work is impressive!
btw: you mention:
In weston-simple-dmabuf-egl I can pass a suitable format on the command line, in my case I use DRM_FORMAT_ABGR8888 (which becomes PIPE_FORMAT_R8G8B8A8_UNORM). With this the panfrost driver does AFBC which then can be rendered in the VOP2 cluster window overlay.
is this mean that: when my app is using ARGB8888 format - then I have AFBC on rk3566?