Re: [PATCH 1/3] drm: Add LCD display clock polarity flags

On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote:

Add DRM flags for the LCD display clock polarity so the pixelclk-active DT property can be properly handled by drivers using the DRM API.

I still say that not even this should be part of the DRM mode API to userspace. The hint that you're changing the user API is that you're modifying a header file below a 'uapi' directory.

The settings of double scan, sync polarity etc are all part of the display mode specification (check CEA-861 documents). Things like pixel clock polarity are not part of the mode specification, they're a property of the display itself and are independent of the mode.

Therefore, they should not be part of struct drm_mode_modeinfo.